Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppc64le multiarch support #2418

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ppc64le multiarch support #2418

wants to merge 4 commits into from

Conversation

sumitd2
Copy link

@sumitd2 sumitd2 commented Sep 14, 2023

*The multiarch image build has been performed successfully (locally) in an Intel Ubuntu 22.04 container.
*A recent version of the image has been tested on a production ppc64le Openshift cluster.

RajeshJeyapaul
RajeshJeyapaul reviewed Feb 22, 2024
View reviewed changes
Copy link

@RajeshJeyapaul RajeshJeyapaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the check for "ppc64el" at line 6 ? thanks

@sumitd2
Copy link
Author

sumitd2 commented Feb 22, 2024 •
edited
Loading

Why the check for "ppc64el" at line 6 ? thanks

Because on line 19, the link
https://storage.googleapis.com/golang/go1.19.8.linux-${arch}.tar.gz
should be
https://storage.googleapis.com/golang/go1.19.8.linux-ppc64le.tar.gz

@RajeshJeyapaul
Copy link

Why the check for "ppc64el" at line 6 ? thanks

Because on line 19, the link https://storage.googleapis.com/golang/go1.19.8.linux-${arch}.tar.gz should be https://storage.googleapis.com/golang/go1.19.8.linux-ppc64le.tar.gz

ok.. used to tag the filename with architecture should be ok... I understand that "ppcel" and "ppcle" both indicates the little endian but some flavours still refer it as "el" (Debian I guess)..Just to ensure that it does not break anywhere if we do similar check on the flavour which still uses "el"..thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RajeshJeyapaul RajeshJeyapaul RajeshJeyapaul left review comments

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@FxKu FxKu Awaiting requested review from FxKu FxKu is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumitd2 @RajeshJeyapaul